Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MockBuilder): imports modules with providers on root level #4613 #4628

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

satanTime
Copy link
Member

closes #4613

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3ed8ae4) compared to base (30f5bd1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4628   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       223           
  Lines         4681      4683    +2     
  Branches      1070      1071    +1     
=========================================
+ Hits          4681      4683    +2     
Impacted Files Coverage Δ
...ks/src/lib/mock-builder/promise/init-ng-modules.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime merged commit 2c024cf into help-me-mom:master Jan 6, 2023
@satanTime satanTime deleted the issues/4613 branch January 6, 2023 13:07
@satanTime
Copy link
Member Author

v14.5.2 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Provider imported by module is deleted if submodule does not provide it
1 participant